-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alex/add latex compiler key #1514
Conversation
When I add a "<Component>" "Advanced Problem" component | ||
Then I see a "<Component>" Problem component | ||
# Flush out the database before the next example executes | ||
And I reset the database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary -- the teardown method of the test should always do this regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singingwolfboy This comes from latest commit in master (this week), see Scenario: I can add Advanced Problem components. It was added by @jzoldak 28.10 in edx/edx-platform@380e7c4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is an unfortunate and sub-obtimal pattern that we don't want to proliferate but are letting go for now. :(
Lettuce has hooks for after_step and after_scenario, but no hook for after_example. The right way to solve this, given the way we have set up our acceptance tests, is to add an after_example hook to our fork of lettuce and submit an upstream PR to the official repo.
I have created a ticket in the testeng backlog for this.
I'm not qualified to review the code, but moving LaTeX to advanced seems like a good idea. @cahrens tells me that some of the funky behavior is known so 👍 |
👍 |
1 similar comment
👍 |
CapaDescriptor.force_save_button, | ||
CapaDescriptor.markdown, | ||
CapaDescriptor.text_customization, | ||
CapaDescriptor.use_latex_compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a comma after the last item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, fixed
Add latex_compiler_key to course settings.
True - will enable problem with latex templates.
False - will disable.
Problem or Html templates, which use latex, should have latex in their names.
Fix for https://edx-wiki.atlassian.net/browse/BLD-426
Special notes:
a) When course author open course (default value for use_latex_compiler is false), he does not see latex problems. Then he changes value to true. And if he will press back, that page will not reload and he will se old templates for advanced problems. He should reload page to see new advanced templates. Html templates are not affected.
@frrrances and @singingwolfboy please review